Force-close channels on reorg only if the funding is unconfirmed #1461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if a channel's funding is locked in and then later reorg'd back to half of the channel's minimum-depth we will immediately force-close the channel. However, this can happen at the fork-point while processing a reorg, and generally reorgs do not reduce the block height at all, making this a rather useless endeavor. Ideally we'd never auto-force-close channels at all due to a reorg, instead simply marking it as inactive until the funding transaction is re-confirmed (or allowing the user to attempt to force-close or force-closing once we're confident we have completed reorg processing if we're at risk of losing funds already received in the channel). Sadly, we currently do not support changing a channel's SCID and updating our SCID maps, so we cannot yet remove the automated force-close logic. Still, there is no reason to do it until a funding transaction has been removed from the chain. This implements that change - only force-closeing once a channel's funding transaction has been reorg'd out (still potentially at a reorg's fork point). This continues to imply a 1-confirmation channel will always be force-closed after a reorg of the funding transaction, and will imply a similar behavior with 0-conf channels.
Merged
Codecov Report
@@ Coverage Diff @@
## main #1461 +/- ##
==========================================
+ Coverage 90.90% 91.13% +0.23%
==========================================
Files 75 75
Lines 41616 43390 +1774
Branches 41616 43390 +1774
==========================================
+ Hits 37829 39544 +1715
- Misses 3787 3846 +59
Continue to review full report at Codecov.
|
TheBlueMatt
force-pushed
the
2022-05-unconf-0-not-half
branch
from
61f097e to
6e5169b
Compare
valentinewallace
previously approved these changes
May 2, 2022
TheBlueMatt
dismissed stale reviews from vincenzopalazzo and valentinewallace
via
3030dba
|
Actually, partially unded that last commit - if we're doing |
valentinewallace
previously approved these changes
May 3, 2022
TheBlueMatt
force-pushed
the
2022-05-unconf-0-not-half
branch
from
3030dba to
1568097
Compare
|
Squashed the last fixup commit |
dunxen
approved these changes
May 3, 2022
arik-so
approved these changes
May 3, 2022
valentinewallace
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a channel's funding is locked in and then later
reorg'd back to half of the channel's minimum-depth we will
immediately force-close the channel. However, this can happen at
the fork-point while processing a reorg, and generally reorgs do
not reduce the block height at all, making this a rather useless
endeavor.
Ideally we'd never auto-force-close channels at all due to a reorg,
instead simply marking it as inactive until the funding
transaction is re-confirmed (or allowing the user to attempt to
force-close or force-closing once we're confident we have
completed reorg processing if we're at risk of losing funds
already received in the channel).
Sadly, we currently do not support changing a channel's SCID and
updating our SCID maps, so we cannot yet remove the automated
force-close logic. Still, there is no reason to do it until a
funding transaction has been removed from the chain.
This implements that change - only force-closeing once a channel's
funding transaction has been reorg'd out (still potentially at a
reorg's fork point). This continues to imply a 1-confirmation
channel will always be force-closed after a reorg of the funding
transaction, and will imply a similar behavior with 0-conf
channels.